Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Davide Italiano via cfe-commits]

davide closed this revision.
davide added a comment.

Close, this went in a while ago.


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Andrew Turner via cfe-commits]

andrew added a comment.

Can someone commit with the FIXME comment? I'm unable to do it myself.


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Davide Italiano via cfe-commits]

davide accepted this revision.
davide added a reviewer: davide.
davide added a comment.
This revision is now accepted and ready to land.

LGTM



Comment at: lib/Driver/Tools.cpp:941
@@ -940,3 +940,3 @@
 
-  // The kext linker doesn't know how to deal with movw/movt.
-  if (KernelOrKext)
+  // The kext and FreeBSD linkers don't know how to deal with movw/movt.
+  if (KernelOrKext || Triple.isOSFreeBSD())

I'd add a FIXME I expect this to be fixed in the foreseeable future.


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Davide Italiano via cfe-commits]

davide added a comment.

In http://reviews.llvm.org/D15791#317172, @dim wrote:

> @davide, any idea whether lld will be able to handle movt correctly?  If so, 
> we might want to make this dependent on `-fuse-ld=bfd` or `-fuse-ld=lld` ?


lld/AArch64 can't still handle that properly, so I'd rather recommend to make 
it dependent on fuse-ld=bfd.

Thanks,

-

Davide


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Ed Maste via cfe-commits]

emaste added a comment.

> @davide, any idea whether lld will be able to handle movt correctly? If so, 
> we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ?


I'm sure lld will handle everything we need eventually (if it does not 
already), but I'm not sure it's reasonable to have different behaviour based on 
`-fuse-ld` here anyhow -- ld.bfd may well be a recent one from ports.


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15791: Disable generating movt on FreeBSD

[Dimitry Andric via cfe-commits]

dim added a comment.

In http://reviews.llvm.org/D15791#317175, @emaste wrote:

> > @davide, any idea whether lld will be able to handle movt correctly? If so, 
> > we might want to make this dependent on -fuse-ld=bfd or -fuse-ld=lld ?
>
>
> I'm sure lld will handle everything we need eventually (if it does not 
> already), but I'm not sure it's reasonable to have different behaviour based 
> on `-fuse-ld` here anyhow -- ld.bfd may well be a recent one from ports.


Right, so this really only applies for binutils ld below a certain version, 
then?  IIRC the linker version on the system is detected at configuration time; 
maybe it can be used instead.  Ideally there would be some sort of runtime 
detection, but it does not sound feasible with ld.


Repository:
  rL LLVM

http://reviews.llvm.org/D15791



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits