rsmith added a comment.
In https://reviews.llvm.org/D29930#974039, @EricWF wrote:
> @rsmith The trait is already documented in `LanguageExtensions.rst`, so I'll
> assumed you missed that and are not trying to suggest more documentation is
> needed.
Yes, sorry, not sure how I missed that! :)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322334: Add `__reference_binds_to_temporary` trait for
checking safe reference… (authored by EricWF, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
EricWF updated this revision to Diff 129544.
EricWF marked an inline comment as done.
EricWF added a comment.
Address inline comments.
https://reviews.llvm.org/D29930
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
EricWF marked 3 inline comments as done.
EricWF added a comment.
@rsmith The trait is already documented in `LanguageExtensions.rst`, so I'll
assumed you missed that and are not trying to suggest more documentation is
needed.
Comment at: include/clang/Basic/TypeTraits.h:91
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Please also document this trait in docs/LanguageExtensions.rst.
Comment at: include/clang/Basic/TypeTraits.h:91
+/// \brief Names for the array type traits.
+enum
EricWF updated this revision to Diff 123741.
EricWF added a comment.
- Address spelling errors pointed out during review.
https://reviews.llvm.org/D29930
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
lib/Parse/ParseDeclCXX.cpp
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: test/SemaCXX/type-traits.cpp:2102-2116
+ using LRef = ConvertsToRef;
+ using RRef = ConvertsToRef;
+ using CLRef = ConvertsToRef;
+ using LongRef =
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4567
- if (Kind <= BTT_Last)
+ // Evaluate BTT_ReferenceBindsToTemporary along side the IsConstructible
+ // traits to avoid duplication.
"alongside" is a single word.
EricWF added a comment.
@rsmith Ping.
https://reviews.llvm.org/D29930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
@rsmith gentle ping.
https://reviews.llvm.org/D29930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF updated this revision to Diff 88795.
EricWF added a comment.
Remove test code that snuck in.
https://reviews.llvm.org/D29930
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
lib/Parse/ParseDeclCXX.cpp
EricWF updated this revision to Diff 88794.
EricWF retitled this revision from "Add `__is_direct_constructible` trait for
checking safe reference initialization." to "Add
`__reference_binds_to_temporary` trait for checking safe reference
initialization.".
EricWF edited the summary of this
12 matches
Mail list logo