bkelley added a comment.
Thank you @rjmccall for the approval. I don't have commit access; would someone
be willing to commit this path for me please? Thanks!
https://reviews.llvm.org/D31006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Sema/SemaCast.cpp:125
+ assert(Self.getLangOpts().ObjCAutoRefCount ||
+ Self.getLangOpts().ObjCWeak);
bkelley
bkelley marked an inline comment as done.
bkelley added inline comments.
Comment at: lib/Sema/SemaCast.cpp:125
+ assert(Self.getLangOpts().ObjCAutoRefCount ||
+ Self.getLangOpts().ObjCWeak);
rjmccall wrote:
> Unlike the other patches, we do
bkelley updated this revision to Diff 92219.
bkelley marked an inline comment as done.
bkelley added a comment.
Updated with feedback from @rjmccall
https://reviews.llvm.org/D31006
Files:
include/clang/Basic/LangOptions.h
include/clang/Sema/Sema.h
lib/Sema/SemaCast.cpp
rjmccall added inline comments.
Comment at: lib/Sema/SemaCast.cpp:125
+ assert(Self.getLangOpts().ObjCAutoRefCount ||
+ Self.getLangOpts().ObjCWeak);
Unlike the other patches, we do clearly need to be checking the language
options in places
bkelley created this revision.
clang should produce the same errors Objective-C classes that cannot be
assigned to weak pointers under both -fobjc-arc and -fobjc-weak. Check for
ObjCWeak along with ObjCAutoRefCount when analyzing pointer conversions. Add an
-fobjc-weak pass to the existing
