[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

2017-06-30 Thread Joey Gouly via Phabricator via cfe-commits
joey added a comment. Thanks! Making that change, going to re-run the tests and then I'll commit. https://reviews.llvm.org/D34871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

2017-06-30 Thread Alexey Bader via Phabricator via cfe-commits
bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Just one minor comment. Thanks. Comment at: clang/Sema/Sema.h:8435 /// \return true if type is disabled. - bool checkOpenCLDisabledDecl(const Decl , const Expr ); +

[PATCH] D34871: [OpenCL] Add function name to extension diagnostic

2017-06-30 Thread Joey Gouly via Phabricator via cfe-commits
joey created this revision. Herald added subscribers: Anastasia, yaxunl. Slightly improve the diagnostic by including the function name. This has been separated out from https://reviews.llvm.org/D33945. https://reviews.llvm.org/D34871 Files: Sema/Sema.cpp SemaOpenCL/extension-begin.cl