[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.
This revision was automatically updated to reflect the committed changes. Closed by commit rL327852: Updated a usage of createTemporaryFile that does not expect file to be created. (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D36828 Files: cfe/trunk/unittests/Tooling/ToolingTest.cpp Index: cfe/trunk/unittests/Tooling/ToolingTest.cpp === --- cfe/trunk/unittests/Tooling/ToolingTest.cpp +++ cfe/trunk/unittests/Tooling/ToolingTest.cpp @@ -319,8 +319,8 @@ TEST(runToolOnCodeWithArgs, TestNoDepFile) { llvm::SmallString<32> DepFilePath; - ASSERT_FALSE( - llvm::sys::fs::createTemporaryFile("depfile", "d", DepFilePath)); + ASSERT_FALSE(llvm::sys::fs::getPotentiallyUniqueTempFileName("depfile", "d", + DepFilePath)); std::vector Args; Args.push_back("-MMD"); Args.push_back("-MT"); Index: cfe/trunk/unittests/Tooling/ToolingTest.cpp === --- cfe/trunk/unittests/Tooling/ToolingTest.cpp +++ cfe/trunk/unittests/Tooling/ToolingTest.cpp @@ -319,8 +319,8 @@ TEST(runToolOnCodeWithArgs, TestNoDepFile) { llvm::SmallString<32> DepFilePath; - ASSERT_FALSE( - llvm::sys::fs::createTemporaryFile("depfile", "d", DepFilePath)); + ASSERT_FALSE(llvm::sys::fs::getPotentiallyUniqueTempFileName("depfile", "d", + DepFilePath)); std::vector Args; Args.push_back("-MMD"); Args.push_back("-MT"); ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Self-LGTMing since it's a trivial follow-up to an accepted change. https://reviews.llvm.org/D36828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.
ilya-biryukov added a comment. A change to llvm repository is here: https://reviews.llvm.org/D36827 https://reviews.llvm.org/D36828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D36828: Updated a usage of createTemporaryFile that does not expect file to be created.
ilya-biryukov created this revision. This fixes a usage of createTemporaryFile in clang repo after a change in llvm repo. https://reviews.llvm.org/D36828 Files: unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/ToolingTest.cpp === --- unittests/Tooling/ToolingTest.cpp +++ unittests/Tooling/ToolingTest.cpp @@ -319,8 +319,8 @@ TEST(runToolOnCodeWithArgs, TestNoDepFile) { llvm::SmallString<32> DepFilePath; - ASSERT_FALSE( - llvm::sys::fs::createTemporaryFile("depfile", "d", DepFilePath)); + ASSERT_FALSE(llvm::sys::fs::getPotentiallyUniqueTempFileName("depfile", "d", + DepFilePath)); std::vector Args; Args.push_back("-MMD"); Args.push_back("-MT"); Index: unittests/Tooling/ToolingTest.cpp === --- unittests/Tooling/ToolingTest.cpp +++ unittests/Tooling/ToolingTest.cpp @@ -319,8 +319,8 @@ TEST(runToolOnCodeWithArgs, TestNoDepFile) { llvm::SmallString<32> DepFilePath; - ASSERT_FALSE( - llvm::sys::fs::createTemporaryFile("depfile", "d", DepFilePath)); + ASSERT_FALSE(llvm::sys::fs::getPotentiallyUniqueTempFileName("depfile", "d", + DepFilePath)); std::vector Args; Args.push_back("-MMD"); Args.push_back("-MT"); ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits