ilya-biryukov added a comment.
In https://reviews.llvm.org/D37282#860239, @puremourning wrote:
> No I don't have commit rights. Can you land for me? Thanks!
Done.
Repository:
rL LLVM
https://reviews.llvm.org/D37282
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312483: clangd: Tolerate additional headers (authored by
ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D37282
Files:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
puremourning added a comment.
In https://reviews.llvm.org/D37282#860200, @ilya-biryukov wrote:
> Looks good and ready to land. Thanks for this change.
> Do you have commit rights to llvm repo?
Thanks for the review!
No I don't have commit rights. Can you land for me? Thanks!
ilya-biryukov added inline comments.
Comment at: clangd/JSONRPCDispatcher.cpp:167
+ // It's another header, ignore it.
continue;
+} else {
puremourning wrote:
> ilya-biryukov wrote:
> > Maybe log the skipped header?
> I think this would just be
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Looks good and ready to land. Thanks for this change.
Do you have commit rights to llvm repo?
https://reviews.llvm.org/D37282
___
puremourning added a comment.
So I think this is ready now. Anything more you need from me?
Comment at: clangd/JSONRPCDispatcher.cpp:138
bool ) {
+ unsigned long long ContentLength = 0;
while (In.good()) {
puremourning
puremourning updated this revision to Diff 113476.
puremourning added a comment.
Validate that the duplicate message is printed.
https://reviews.llvm.org/D37282
Files:
clangd/JSONRPCDispatcher.cpp
test/clangd/protocol.test
Index: test/clangd/protocol.test
