This revision was automatically updated to reflect the committed changes.
Closed by commit rL329442: Generate Libclang invocation reproducers using a new
-cc1gen-reproducer (authored by arphaman, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
arphaman added a comment.
In https://reviews.llvm.org/D40983#1059087, @arphaman wrote:
> In https://reviews.llvm.org/D40983#968796, @bruno wrote:
>
> > Makes sense, LGTM.
> >
> > Should we add documentation explaining how to use this? I'm fine if it
> > comes in a follow up commit.
>
>
> Sorry,
arphaman added a comment.
In https://reviews.llvm.org/D40983#968796, @bruno wrote:
> Makes sense, LGTM.
>
> Should we add documentation explaining how to use this? I'm fine if it comes
> in a follow up commit.
Sorry, just got time to get back to this now. Thanks for the review! I'll add a
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Makes sense, LGTM.
Should we add documentation explaining how to use this? I'm fine if it comes in
a follow up commit.
https://reviews.llvm.org/D40983
arphaman updated this revision to Diff 127935.
arphaman marked an inline comment as done.
arphaman added a comment.
Address review comments
https://reviews.llvm.org/D40983
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
test/Index/create-libclang-completion-reproducer.c
arphaman marked 2 inline comments as done.
arphaman added a comment.
In https://reviews.llvm.org/D40983#958809, @bruno wrote:
> Hi Alex,
>
> Thanks for improving this.
>
> - Instead of adding `-cc1gen-reproducer`, why can't you run that through
> `-cc1` and have a flag similar to `-###`, which
bruno added a comment.
Hi Alex,
Thanks for improving this.
- Instead of adding `-cc1gen-reproducer`, why can't you run that through `-cc1`
and have a flag similar to `-###`, which just prints the reproducer line?
- I didn't understand how you can use the final output information, can you
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch is a follow up to the previous work that recorded Libclang
invocations into temporary files: https://reviews.llvm.org/D40527.
It adds a new -cc1 mode to clang: `-cc1gen-reproducer`. The goal of this mode
is to
