This revision was automatically updated to reflect the committed changes.
Closed by commit rL338578: [Format] Fix for bug 35641 (authored by ibiryukov,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43303?vs=134830=158546#toc
kadircet added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D43303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet updated this revision to Diff 134830.
kadircet added a comment.
Rebased and uploaded diff to the master. Sorry for the inconvenience.
Repository:
rC Clang
https://reviews.llvm.org/D43303
Files:
lib/Format/WhitespaceManager.cpp
unittests/Format/FormatTest.cpp
Index:
lebedev.ri added a comment.
The diff looks wrong, the `lib/Format/WhitespaceManager.cpp` change gone
missing.
You need to upload the diff to the `git master`/svn trunk/etc, *NOT* to the
previous commit (previous diff).
Repository:
rC Clang
https://reviews.llvm.org/D43303
kadircet added a comment.
Btw, I cannot commit the change myself, don't have commit rights.
Repository:
rC Clang
https://reviews.llvm.org/D43303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kadircet updated this revision to Diff 134414.
kadircet added a comment.
Changed description of unit test to include direct link to bug.
Used different variable types to make sure alignment happens.
Repository:
rC Clang
https://reviews.llvm.org/D43303
Files:
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Thanks for the fix.
Comment at: unittests/Format/FormatTest.cpp:9453
+
+ // Bug 35641
+ Alignment.AlignConsecutiveDeclarations = true;
Make this "See
kadircet created this revision.
kadircet added reviewers: rsmith, djasper.
kadircet added a project: clang.
Herald added a subscriber: cfe-commits.
Bug was caused due to comments at the start of scope. For a code like:
int func() { //
int b;
int c;
}
the comment at the first line
