[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-13 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC353957: [AArch64] Support reserving arbitrary general purpose registers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D56305?vs=186583=186687#toc Repository:

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-12 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); efriedma wrote: > trong wrote: > > trong wrote: > > > phosek wrote: > > > > trong

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-12 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 186583. phosek marked 5 inline comments as done. phosek edited the summary of this revision. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305 Files:

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-12 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); trong wrote: > trong wrote: > > phosek wrote: > > > trong wrote: > > > > What

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-12 Thread Tri Vo via Phabricator via cfe-commits
trong accepted this revision. trong added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); trong

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-12 Thread Tri Vo via Phabricator via cfe-commits
trong added inline comments. Herald added a project: LLVM. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:318 + if (Args.hasArg(options::OPT_ffixed_x0)) +Features.push_back("+reserve-x0"); phosek wrote: > trong wrote: > > What happens (should

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D56305#1363417 , @carwil wrote: > Hi, we're currently working on similar functionality for the ARM backend, so > I got pointed to take a look at this patch. > Looks good to me, I quite like the tablegen improvements, but agree

[PATCH] D56305: [AArch64] Support reserving arbitrary general purpose registers

2019-02-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 185667. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56305/new/ https://reviews.llvm.org/D56305