[PATCH] D57965: Clean up ObjCPropertyDecl printing

This revision was automatically updated to reflect the committed changes. Closed by commit rL357937: Clean up ObjCPropertyDecl printing (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 194195. dgoldman added a comment. Herald added a subscriber: dexonsmith. - Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp

[PATCH] D57965: Clean up ObjCPropertyDecl printing

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for working on this! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189318. dgoldman added a comment. - Fix broken test by last change Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman updated this revision to Diff 189317. dgoldman added a comment. - Add more tests and improved printing of pointers Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 Files: lib/AST/DeclPrinter.cpp

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. In D57965#1417361 , @jkorous wrote: > Hi David, > I am just wondering - while you're here would you mind adding couple more > tests? It would be great to have a test for each attribute. > > Also, what do you think about Ben's

[PATCH] D57965: Clean up ObjCPropertyDecl printing

jkorous added a comment. Hi David, I am just wondering - while you're here would you mind adding couple more tests? It would be great to have a test for each attribute. Also, what do you think about Ben's suggestion? I think it would be nice to be consistent with the style Objective-C

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. Friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57965: Clean up ObjCPropertyDecl printing

benlangmuir added a comment. > @property(attr, attr2) instead of @property ( attr,attr2 ). The style I see most often is `@property (attr, attr2)`, which is in between those two. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/

[PATCH] D57965: Clean up ObjCPropertyDecl printing

benlangmuir added subscribers: akyrtzi, benlangmuir. benlangmuir added a comment. @arphaman @akyrtzi could you take a look at this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman created this revision. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. - `@property(attr, attr2)` instead of `@property ( attr,attr2 )`. - Change priority of attributes (see code/comments inline). - Support for printing weak and unsafe_unretained