[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

This revision was automatically updated to reflect the committed changes. boga95 marked 2 inline comments as done. Closed by commit rG89bc4c662c6c: [analyzer] Add custom filter functions for GenericTaintChecker (authored by boga95). Changed prior to commit:

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. See also https://llvm.org/docs/DeveloperPolicy.html#current-contributors-transfering-from-svn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits mailing list

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. You're now supposed to push directly to github. You might also have missed http://lists.llvm.org/pipermail/cfe-dev/2019-August/063219.html. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 2 inline comments as done. boga95 added a comment. I did the required changes and tried to commit it, but I couldn't. I heard the codebase was migrated to GitHub. Maybe it affected my commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, provided that the inlines are addressed! Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:102-103 /// system call etc. - bool

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ accepted this revision. NoQ added a comment. @NoQ: "Why not simply remove taint?" @boga95: //*removes taint*// @NoQ: "Hmm, now that i think about it, adding a 'no taint' marker might actually work correctly more often." Like, if you have taint on `$x` and try to remove taint from

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

steakhal added a comment. I think this patch is ok. Although there are remarks: - I think the current implementation of the taint filtering functions does not follow the expected semantics. Now the modelling would remove taint before calling the function (//pre statement//). One might expect

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 2 inline comments as done. boga95 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 marked 7 inline comments as done. boga95 added a comment. Ping Comment at: clang/test/Analysis/taint-generic.c:393-397 +void testConfigurationFilter3() { + int x = mySource1(); + myFilter3(); + Buffer[x] = 1; // no-warning +} NoQ wrote: > In this

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 220385. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:517 +if (V) + State = addTaint(State, *V, TaintTagNotTainted); + } Why not simply remove taint? CHANGES SINCE LAST ACTION

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. I'd like the test cases to actually demonstrate the correct use of the filters and the correct behavior of the Analyzer when the filters are annotated correctly, but it looks to me that they either demonstrate behavior when the annotation is //not// used correctly, or we

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 219981. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/lib/StaticAnalyzer/Checkers/Taint.cpp

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

Szelethus added a comment. In general, the patch is looking alright, I'll take a second look later on. Don't mind my inlines too much, they are more directed towards the original code then your changes. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:53-56 +

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 193705. boga95 added a comment. Rebase after https://reviews.llvm.org/D59861. Fix custom filter test case: functions without definition always remove taintedness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. Hi, i wanted to squeeze in D59861 somewhere in the middle of your work, would you mind? I'll definitely have a look at your patches soon :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 added a comment. I add a new taint type, which represents a lack of taintedness. That's why I changed the name of `addTaint()` to `setTaint()`. Of course, it's not an important change, I can move it to another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Same thing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516 ___ cfe-commits

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 updated this revision to Diff 191668. boga95 retitled this revision from "[analyzer] Make GenericTaintChecker configurable" to "[analyzer] Add custom filter functions for GenericTaintChecker". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/