[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Reverted in r357612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D60213: Add clangTooling dependency to fix the build.

That would be great, thank you. On Wed, Apr 3, 2019 at 1:28 PM Alexey Bataev via Phabricator < revi...@reviews.llvm.org> wrote: > ABataev added a comment. > > I can revert it for you, if you want > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION >

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. I can revert it for you, if you want Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60213/new/ https://reviews.llvm.org/D60213 ___ cfe-commits mailing list

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel added a comment. In D60213#1453516 , @ABataev wrote: > Nope, it won't work. There is a cyclic dependency, unfortunately. > clangTooling depends on clangToolingRefactor already. You need to revert your > commit and refactor it to remove the

[PATCH] D60213: Add clangTooling dependency to fix the build.

ABataev added a comment. Nope, it won't work. There is a cyclic dependency, unfortunately. clangTooling depends on clangToolingRefactor already. You need to revert your commit and refactor it to remove the cyclic dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60213: Add clangTooling dependency to fix the build.

ymandel created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Fixes https://reviews.llvm.org/D59371, which broke the build for shared libraries. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60213 Files: