[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added inline comments. Comment at: unittests/AST/ASTTraverserTest.cpp:75 + +template std::string dumpASTString(NodeType &&... N) { + std::string Buffer; steveire wrote: > aaron.ballman wrote: > > Did clang-format produce this formatting? (If not,

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

This revision was automatically updated to reflect the committed changes. steveire marked an inline comment as done. Closed by commit rL361033: Add a Visit overload for DynTypedNode to ASTNodeTraverser (authored by steveire, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire marked 5 inline comments as done. steveire added inline comments. Comment at: unittests/AST/ASTTraverserTest.cpp:75 + +template std::string dumpASTString(NodeType &&... N) { + std::string Buffer; aaron.ballman wrote: > Did clang-format produce this

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D61834#1505418 , @steveire wrote: > In D61834#1505124 , @aaron.ballman > wrote: > > > In

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire updated this revision to Diff 12. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 Files: include/clang/AST/ASTNodeTraverser.h unittests/AST/ASTTraverserTest.cpp

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire updated this revision to Diff 199922. steveire added a comment. Herald added a subscriber: mgorny. Add basic traverser test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 Files:

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire added a comment. In D61834#1505124 , @aaron.ballman wrote: > In D61834#1505056 , @steveire wrote: > > > In D61834#1504665 , @aaron.ballman > > wrote: > > > > >

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added a comment. In D61834#1505056 , @steveire wrote: > In D61834#1504665 , @aaron.ballman > wrote: > > > What will be making use of/testing this new functionality? > > > Any code which has a

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire added a comment. In D61834#1504665 , @aaron.ballman wrote: > What will be making use of/testing this new functionality? Any code which has a `DynTypedNode` and wishes to traverse it. I envisage this as a more-flexible `DynTypedNode::dump`

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

aaron.ballman added a comment. What will be making use of/testing this new functionality? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 ___ cfe-commits mailing list

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire updated this revision to Diff 199178. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61834/new/ https://reviews.llvm.org/D61834 Files: include/clang/AST/ASTNodeTraverser.h Index: include/clang/AST/ASTNodeTraverser.h

[PATCH] D61834: Add a Visit overload for DynTypedNode to ASTNodeTraverser

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61834 Files: include/clang/AST/ASTNodeTraverser.h Index: include/clang/AST/ASTNodeTraverser.h