martong marked 2 inline comments as done.
martong added inline comments.
Comment at: cfe/trunk/lib/AST/ASTStructuralEquivalence.cpp:173
+DE2->getQualifier());
+ } else if (auto CastE1 = dyn_cast(E1)) {
+auto *CastE2 = dyn_cast(E2);
a_sidorin added inline comments.
Comment at: cfe/trunk/lib/AST/ASTStructuralEquivalence.cpp:173
+DE2->getQualifier());
+ } else if (auto CastE1 = dyn_cast(E1)) {
+auto *CastE2 = dyn_cast(E2);
Hi Gabor,
Is there any test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364889: [ASTImporter] Structural eq: handle
DependentScopeDeclRefExpr (authored by martong, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
martong updated this revision to Diff 207354.
martong added a comment.
- Handle ImplicitCastExpr. In Clang7 in the last two test cases we did not have
any ImplicitCastExpr in the AST. With never Clang we have, so we must handle
the cast expr too.
Repository:
rG LLVM Github Monorepo
CHANGES
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the fixes!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62329/new/
https://reviews.llvm.org/D62329
martong added a comment.
Alexei, thank you very much for the review, you caught quite a few missing
things!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62329/new/
https://reviews.llvm.org/D62329
martong marked 8 inline comments as done.
martong added inline comments.
Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124
+ case DeclarationName::CXXConversionFunctionName:
+return true;
+
a_sidorin wrote:
> Should we check the equivalence of
martong updated this revision to Diff 207063.
martong marked 4 inline comments as done.
martong added a comment.
- Add further checks for the DeclarationName overload
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62329/new/
a_sidorin added a comment.
Hello Gabor,
I have a few questions inline.
Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124
+ case DeclarationName::CXXConversionFunctionName:
+return true;
+
Should we check the equivalence of getCXXNameType() in
martong created this revision.
martong added a reviewer: a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a project: clang.
Structural equivalence did not handle dependent template args properly
when the arg
10 matches
Mail list logo