[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364267: [analyzer] NFC: exploded-graph-rewriter: Extract
some code into functions. (authored by dergachev, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D63684?vs=206112=206353#toc
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63684/new/
https://reviews.llvm.org/D63684
Files:
cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
Index: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
===
--- cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
+++ cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
@@ -409,6 +409,24 @@
self._dump('')
+def visit_environment_in_state(self, s, prev_s=None):
+self._dump(''
+ 'Environment: ')
+if s.environment is None:
+self._dump(' Nothing!')
+else:
+if prev_s is not None and prev_s.environment is not None:
+if s.environment.is_different(prev_s.environment):
+self._dump('')
+self.visit_environment(s.environment, prev_s.environment)
+else:
+self._dump(' No changes!')
+else:
+self._dump('')
+self.visit_environment(s.environment)
+
+self._dump('')
+
def visit_store(self, s, prev_s=None):
self._dump('')
@@ -447,8 +465,7 @@
self._dump('')
-def visit_state(self, s, prev_s):
-# == Store ==
+def visit_store_in_state(self, s, prev_s=None):
self._dump('Store: ')
if s.store is None:
self._dump(' Nothing!')
@@ -464,23 +481,9 @@
self.visit_store(s.store)
self._dump('')
-# == Environment ==
-self._dump(''
- 'Environment: ')
-if s.environment is None:
-self._dump(' Nothing!')
-else:
-if prev_s is not None and prev_s.environment is not None:
-if s.environment.is_different(prev_s.environment):
-self._dump('')
-self.visit_environment(s.environment, prev_s.environment)
-else:
-self._dump(' No changes!')
-else:
-self._dump('')
-self.visit_environment(s.environment)
-
-self._dump('')
+def visit_state(self, s, prev_s):
+self.visit_store_in_state(s, prev_s)
+self.visit_environment_in_state(s, prev_s)
def visit_node(self, node):
self._dump('%s [shape=record,label=<'
Index: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
===
--- cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
+++ cfe/trunk/utils/analyzer/exploded-graph-rewriter.py
@@ -409,6 +409,24 @@
self._dump('')
+def visit_environment_in_state(self, s, prev_s=None):
+self._dump(''
+ 'Environment: ')
+if s.environment is None:
+self._dump(' Nothing!')
+else:
+if prev_s is not None and prev_s.environment is not None:
+if s.environment.is_different(prev_s.environment):
+self._dump('')
+self.visit_environment(s.environment, prev_s.environment)
+else:
+self._dump(' No changes!')
+else:
+self._dump('')
+self.visit_environment(s.environment)
+
+self._dump('')
+
def visit_store(self, s, prev_s=None):
self._dump('')
@@ -447,8 +465,7 @@
self._dump('')
-def visit_state(self, s, prev_s):
-# == Store ==
+def visit_store_in_state(self, s, prev_s=None):
self._dump('Store: ')
if s.store is None:
self._dump(' Nothing!')
@@ -464,23 +481,9 @@
self.visit_store(s.store)
self._dump('')
-# == Environment ==
-self._dump(''
- 'Environment: ')
-if s.environment is None:
-self._dump(' Nothing!')
-else:
-if prev_s is not None and prev_s.environment is not None:
-if s.environment.is_different(prev_s.environment):
-self._dump('')
-self.visit_environment(s.environment, prev_s.environment)
-else:
-self._dump(' No changes!')
-else:
-self._dump('')
-self.visit_environment(s.environment)
-
-self._dump('')
+def visit_state(self, s, prev_s):
+self.visit_store_in_state(s, prev_s)
+self.visit_environment_in_state(s, prev_s)
def visit_node(self, node):
self._dump('%s
[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.
Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I like that abstraction! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63684/new/ https://reviews.llvm.org/D63684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.
NoQ created this revision.
NoQ added a reviewer: Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.
Even though this code is not duplicated yet, follow-up patches will demonstrate
that it's a nicer way to structure this code.
Repository:
rC Clang
https://reviews.llvm.org/D63684
Files:
clang/utils/analyzer/exploded-graph-rewriter.py
Index: clang/utils/analyzer/exploded-graph-rewriter.py
===
--- clang/utils/analyzer/exploded-graph-rewriter.py
+++ clang/utils/analyzer/exploded-graph-rewriter.py
@@ -410,6 +410,24 @@
self._dump('')
+def visit_environment_in_state(self, s, prev_s=None):
+self._dump(''
+ 'Environment: ')
+if s.environment is None:
+self._dump(' Nothing!')
+else:
+if prev_s is not None and prev_s.environment is not None:
+if s.environment.is_different(prev_s.environment):
+self._dump('')
+self.visit_environment(s.environment, prev_s.environment)
+else:
+self._dump(' No changes!')
+else:
+self._dump('')
+self.visit_environment(s.environment)
+
+self._dump('')
+
def visit_store(self, s, prev_s=None):
self._dump('')
@@ -448,8 +466,7 @@
self._dump('')
-def visit_state(self, s, prev_s):
-# == Store ==
+def visit_store_in_state(self, s, prev_s=None):
self._dump('Store: ')
if s.store is None:
self._dump(' Nothing!')
@@ -465,23 +482,9 @@
self.visit_store(s.store)
self._dump('')
-# == Environment ==
-self._dump(''
- 'Environment: ')
-if s.environment is None:
-self._dump(' Nothing!')
-else:
-if prev_s is not None and prev_s.environment is not None:
-if s.environment.is_different(prev_s.environment):
-self._dump('')
-self.visit_environment(s.environment, prev_s.environment)
-else:
-self._dump(' No changes!')
-else:
-self._dump('')
-self.visit_environment(s.environment)
-
-self._dump('')
+def visit_state(self, s, prev_s):
+self.visit_store_in_state(s, prev_s)
+self.visit_environment_in_state(s, prev_s)
def visit_node(self, node):
self._dump('%s [shape=record,label=<'
Index: clang/utils/analyzer/exploded-graph-rewriter.py
===
--- clang/utils/analyzer/exploded-graph-rewriter.py
+++ clang/utils/analyzer/exploded-graph-rewriter.py
@@ -410,6 +410,24 @@
self._dump('')
+def visit_environment_in_state(self, s, prev_s=None):
+self._dump(''
+ 'Environment: ')
+if s.environment is None:
+self._dump(' Nothing!')
+else:
+if prev_s is not None and prev_s.environment is not None:
+if s.environment.is_different(prev_s.environment):
+self._dump('')
+self.visit_environment(s.environment, prev_s.environment)
+else:
+self._dump(' No changes!')
+else:
+self._dump('')
+self.visit_environment(s.environment)
+
+self._dump('')
+
def visit_store(self, s, prev_s=None):
self._dump('')
@@ -448,8 +466,7 @@
self._dump('')
-def visit_state(self, s, prev_s):
-# == Store ==
+def visit_store_in_state(self, s, prev_s=None):
self._dump('Store: ')
if s.store is None:
self._dump(' Nothing!')
@@ -465,23 +482,9 @@
self.visit_store(s.store)
self._dump('')
-# == Environment ==
-self._dump(''
- 'Environment: ')
-if s.environment is None:
-self._dump(' Nothing!')
-else:
-if prev_s is not None and prev_s.environment is not None:
-if s.environment.is_different(prev_s.environment):
-self._dump('')
-self.visit_environment(s.environment, prev_s.environment)
-else:
-self._dump(' No changes!')
-else:
-self._dump('')
-self.visit_environment(s.environment)
-
-self._dump('')
+def visit_state(self, s, prev_s):
+self.visit_store_in_state(s, prev_s)
+self.visit_environment_in_state(s, prev_s)
def visit_node(self, node):
self._dump('%s [shape=record,label=<'
___
cfe-commits mailing list
