[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rL364551: [clangd] Emit semantic highlighting tokens when the main AST is built. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Let's rephrase the commit message, I think this patch is just to "emit the semantic highlighting tokens when the main AST is built". Comment at:

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom updated this revision to Diff 206854. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Made test safe again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63821/new/ https://reviews.llvm.org/D63821 Files:

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:60 + void + onHighlightingsReady(PathRef File, + std::vector Highlightings) override; jvikstrom wrote: > hokein wrote: > > nit: you can remove this

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:60 + void + onHighlightingsReady(PathRef File, + std::vector Highlightings) override; hokein wrote: > nit:

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom updated this revision to Diff 206841. jvikstrom marked an inline comment as done. jvikstrom added a comment. Simplified test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63821/new/ https://reviews.llvm.org/D63821 Files:

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:60 + void + onHighlightingsReady(PathRef File, + std::vector Highlightings) override; nit: you can remove this override, since we have provided an empty

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom updated this revision to Diff 206832. jvikstrom marked 9 inline comments as done. jvikstrom added a comment. Separated test and gave consumer an empty definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63821/new/

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

hokein added a comment. thanks, it is much clearer now. Could you please make the commit message be more specific what this patch does? C++ APIs is too generous, (we already have C++ APIs and data structures for semantic highlightings which are in `SemanticHighlighting.h`).

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

nik added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:60 + // Called by ClangdServer when some \p Highlightings for \p File are ready. + virtual void onHighlightingsReady(PathRef File, + std::vector Highlightings) = 0;

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom marked 2 inline comments as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:60 + // Called by ClangdServer when some \p Highlightings for \p File are ready. + virtual void onHighlightingsReady(PathRef File, +

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom updated this revision to Diff 206792. jvikstrom added a comment. Herald added a subscriber: jfb. Moved semantic highlighting to be processed in onMainAST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63821/new/

[PATCH] D63821: [clangd] Added C++ API code for semantic highlighting

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, javed.absar. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63821 Files: