[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

This revision was automatically updated to reflect the committed changes. Closed by commit rL369042: [WebAssembly] Correctly handle va_arg of zero-sized structures (authored by quantum, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; dschuff wrote: > This should maybe be called "test_empty_struct" since its size is actually 1 > and not zero.

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum updated this revision to Diff 215272. quantum marked 6 inline comments as done. quantum added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66255/new/ https://reviews.llvm.org/D66255 Files:

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

dschuff added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; This should maybe be called "test_empty_struct" since its size is actually 1 and not zero.

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum created this revision. quantum added reviewers: dschuff, tlively, sbc100. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google. Herald added a project: clang. D66168 passes size 0 structs indirectly, while the wasm backend expects it