[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

rnk added a comment. I posted a patch to speed things up: https://reviews.llvm.org/D72984 The numbers are different, since 9 seconds is measured in a local linux build with no debug info, vs. 28s I measured when building at work, on Windows, with debug info. Repository: rG LLVM Github

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

rnk added a comment. `ArmMveAliasValid` is the second slowest function to compile in all of clang, according to ClangBuildAnalyzer: https://reviews.llvm.org/P8185 We shouldn't spend 28 CPU seconds per rebuild on a switch. Please do something to speed it up. Generally, it is best to emit tables

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/utils/TableGen/CMakeLists.txt:17 NeonEmitter.cpp + MveEmitter.cpp TableGen.cpp thakis wrote: > nit: These files are listed alphabetically. Sorry about

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

thakis added inline comments. Comment at: clang/utils/TableGen/CMakeLists.txt:17 NeonEmitter.cpp + MveEmitter.cpp TableGen.cpp nit: These files are listed alphabetically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. I've hopefully fixed the build in rG7b3de1e81197 , but it's hard to tell for sure with the other error. I also fixed the tests in rG78700ef8866d

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. Hmm.. Let me take a look. There's a different error on the same build now, but I think it's just hiding this one. I'll also try and fix the tests that are failing in places too, if I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

Yi-Hong.Lyu added a comment. Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67161/new/ https://reviews.llvm.org/D67161

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. I've read this through again and it looks good. If no one else has any issues, then LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added subscribers: samparker, SjoerdMeijer. dmgreen added a comment. This is looking good to me. My understanding is that is has some dependencies? The llvm side will likely needed to go in first, plus a couple of clang patches? Comment at:

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

simon_tatham marked 20 inline comments as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8529 "argument should be a multiple of %0">; +def err_argument_not_power_of_2 : Error< + "argument should be a power of 2">;

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_mve_defs.td:119 +// The type Void can be used for the return type of an intrinsic, and as the +// parameter type for intrinsics that aren't actually parametrised by any kind +// of _s32 / _f16 / _u8 suffix.

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. Sorry. I wasn't ignoring this (sort-of), I just knew that you were on holiday and this is a bit of a big one. But I like this. I still have to take a deeper look into the main tablegen parts, but it looks very powerful. I presume from here adding new intrinsics is