[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb76dc111dd02: [analyzer] NFC: Move IssueHash to libAnalysis. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 ___ cfe-commits mailing

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ updated this revision to Diff 283108. NoQ added a comment. Herald added a subscriber: steakhal. Get rid of the "V1" suffix. Indeed, we'll just rename the API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 Files:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

vsavchenko added a comment. Other then the naming issue, I don't see any problems with this change! Comment at: clang/lib/Analysis/IssueHash.cpp:183 -std::string clang::GetIssueString(const SourceManager , - FullSourceLoc , -

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/IssueHash.h:35 +/// /// In case a new hash is introduced, the old one should still be maintained for /// a while. One should not introduce a new hash for every change, it is Szelethus wrote:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ updated this revision to Diff 281797. NoQ marked 5 inline comments as done. NoQ added a comment. Rebase! Re-do the comments. Rename `GetIssueHash()` to `getIssueHashV1` because there's a high chance we'll want more different kinds of hashes (also starts with a small letter, while we're at

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

Szelethus added inline comments. Herald added subscribers: ASDenysPetrov, martong. Comment at: clang/include/clang/Analysis/IssueHash.h:35 +/// /// In case a new hash is introduced, the old one should still be maintained for /// a while. One should not introduce a new hash

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

gribozavr added inline comments. Comment at: clang/include/clang/Analysis/IssueHash.h:18 /// Get an MD5 hash to help identify bugs. /// Returns an opaque identifier for a diagnostic. This opaque identifier is intended to be stable even when the source code

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ updated this revision to Diff 219824. NoQ added a comment. Rename `BugType` to `WarningMessage`, add comments. Get rid of an unnecessary `SourceManager` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 Files:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ added a comment. In D67421#1666058 , @gribozavr wrote: > The "bugtype" in IssueHash is specific to Static Analyzer (or at least not > documented sufficiently abstractly). Yeah, i'll need to document this. That's basically the warning message; it

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

gribozavr added a comment. The "bugtype" in IssueHash is specific to Static Analyzer (or at least not documented sufficiently abstractly). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, mgorny. Herald added a project: clang.