[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

sylvestre.ledru added a comment. Firefox uses a unified build model. For better performances in the binary, the C++ files are compiled as the same time from a single file (ex: Unified_cpp_netwerk_base3.cpp) which will include the .cpp files. This isn't a common use case, so, don't hesitate to

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs added a comment. re-landed in https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

aaron.ballman added a comment. LGTM with the changes for #import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 ___ cfe-commits mailing list

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249377. jroelofs added a comment. Don't fire on `#import`s. The error on Windows suggests it would normally do the "right" thing anyway: http://45.33.8.238/win/10088/step_8.txt

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

thakis added a comment. Reverted for now in 714466bf367dfd5062e1850179d27c37a9ec6b46 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

thakis added a comment. Test falls in Windows: http://45.33.8.238/win/10088/step_8.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 ___ cfe-commits mailing

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 6 inline comments as done. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:101 +- New :doc:`bugprone-suspicious-includei + ` check. Please keep alphabetical order. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:104 + +

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249224. jroelofs added a comment. Add missing release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249223. jroelofs added a comment. Implement review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs closed this revision. jroelofs marked 7 inline comments as done. jroelofs added a comment. Thanks for the review! https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67 Comment at:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some documentation and testing nits. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-include.rst:15-17 + #include

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249164. jroelofs added a comment. Fix comment, add docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 3 inline comments as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:9 + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEADER_FILE_EXTENSIONS_UTILS_H +#define

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + njames93 wrote: > lebedev.ri wrote: > > njames93 wrote: > > >

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + lebedev.ri wrote: > njames93 wrote: > > A lot of configuration

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:38 +/// extensions. +inline StringRef defaultHeaderFileExtensions() { return ",h,hh,hpp,hxx"; } + njames93 wrote: > A lot of configuration options for clang

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248246. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248208. jroelofs marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248203. jroelofs added a comment. Split out https://reviews.llvm.org/D75621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 2 inline comments as done. jroelofs added a comment. In D74669#1902107 , @njames93 wrote: > Adding the parent revision means you don't need to have those changes in this > patch. IIUC, that is what I've already done:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

njames93 added a comment. Adding the parent revision means you don't need to have those changes in this patch. It will cause issues down the line. best thing is to run a diff from this to the parent and just include those changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 247764. jroelofs added a comment. implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: