[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. Many of the changes which were part of a previous iteration of this change were related to the change of default behavior of matchers. As the default is no longer changed, those changes fell away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 300630. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 300629. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

aaron.ballman added a comment. I reviewed the changes in the patch and they seem reasonable, but this patch is hard to have high confidence in because you need to audit all the places where the default behavior silently changed and no changes were made in the patch. I'm assuming that the code

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. Here's another example where it is not appropriate to transform a template instantiation: http://clang-developers.42468.n3.nabble.com/Questions-discussions-about-cast-types-in-clang-td4068626.html "If we call foo, it can be a const_cast, but if we call foo, it has to

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2099262 , @steveire wrote: > In D80961#2095254 , @klimek wrote: > > > 1. the scare quotes around "standing objections" reads like you're not > > respecting the opinions of others

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2095254 , @klimek wrote: > 1. the scare quotes around "standing objections" reads like you're not > respecting the opinions of others here; Hmm, this wasn't intended. I sometimes quote things if they are a particular

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2090216 , @steveire wrote: > In D80961#2079419 , @aaron.ballman > wrote: > > > In D80961#2079044 , @klimek wrote: > > > > > In

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270517. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270472. steveire edited the summary of this revision. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files:

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2079419 , @aaron.ballman wrote: > In D80961#2079044 , @klimek wrote: > > > In D80961#2076242 , @aaron.ballman > > wrote: > > > > > In

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

aaron.ballman added a comment. In D80961#2079044 , @klimek wrote: > In D80961#2076242 , @aaron.ballman > wrote: > > > In D80961#2073049 , @klimek wrote: > > > > > Without

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

klimek added a comment. In D80961#2076242 , @aaron.ballman wrote: > In D80961#2073049 , @klimek wrote: > > > Without jumping into the discussion whether it should be the default, I > > think we should be able to

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

sammccall added a comment. Yeah, I think this is consistent with the naming/doc of IgnoreUnlessSpelledInSource, and the concerns are more about the implications of making a less-powerful, more conservative version of matchers the default. Which isn't really what *this* patch is about, but it's

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2074915 , @steveire wrote: > I don't think that's true. You have to change the matchers you've written > which deliberately match the instantiation, but you can also (optionally) > simplify the others to remove

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 269081. steveire added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. Port unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961