[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3bdc9814d94: [clang-tidy] Reworked enum options handling(again) (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82188?vs=275520=277227#toc Repository: rG LLVM Github

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 275520. njames93 added a comment. Solved the mac issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:225 +// FIXME: Figure out why this test causes crashes on mac os. +#ifndef __APPLE__ @aaron.ballman @thakis I

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2119980 , @thakis wrote: > In this case, trunk was broken for > 12h, so I'd expect there's lots of > evidence of this being broken on cmake bots too. However, the mac bots aren't > on buildbot but on

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. In D82188#2119393 , @njames93 wrote: > @thakis Do those bots use `gn`, could that be the cause of the failures? It's possible, but unlikely, given that your change doesn't touch any build files. …and indeed, I checked out

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 274012. njames93 added a comment. Figuring out mac crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. @thakis Do those bots use `gn`, could that be the cause of the failures? From what I can see `gn` isn't fully supported by llvm and could certainly be the cause of failing builds. Do we have any build bots on mac that don't use `gn` but passed the test case?

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:31 + ~TestCheck() { +assert(DidRegister && "Check never registered"); +assert(DidFire && "Check never

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. I've relanded this with some sanity checks in 37cc4fa2eaa3d03ca8cd4947eb0d4c60e3c9b45c . If it fails again without those asserts I'll go back to the drawing board Repository: rG LLVM Github

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2118885 , @thakis wrote: > It's the only change on the blame list, things pass consistently before the > change, and fail consistently after it. Do you happen to have a proper build log for the failing build. That

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. I reverted this in 8f73c4432b5fa8510c99a5053c07dc70a610e1fb and check-clang-tools stopped failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. It's the only change on the blame list, things pass consistently before the change, and fail consistently after it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9306fd042ce: [clang-tidy] Reworked enum options handling(again) (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2118769 , @thakis wrote: > This breaks chevk-clang-tools in mac: http://45.33.8.238/mac/16292/step_8.txt > > Please take a look and revert for now if it takes a while to fix. Are you sure that this is the offending

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. This breaks chevk-clang-tools in mac: http://45.33.8.238/mac/16292/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 272336. njames93 added a comment. - Fix compilation failure on rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files:

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:31-32 +template struct OptionEnumMapping { + // Must provide: + // static ArrayRef> getEnumMapping(); +}; aaron.ballman wrote: > Any reason not to do: > ``` > static

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 272317. njames93 marked 2 inline comments as done. njames93 added a comment. Use `= delete` for getEnumMapping in template definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I like the direction of this, thank you! LGTM with a small suggestion, but you should wait a few days in case one of the other reviewers has comments. Comment

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 272306. njames93 added a comment. Update doc comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscriber: wuzish. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:30 Options.store(Opts, "GslHeader", GslHeader);

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Following on from D77085 , I was never happy with the