[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc752b30b9a: [CUDA][HIP] Always defer diagnostics for wrong-sided reference (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83893/new/ https://reviews.llvm.org/D83893 ___ cfe-commits mailing list

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

jlebar added a comment. tra and I talked offline and I...think this makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83893/new/ https://reviews.llvm.org/D83893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

tra added subscribers: jlebar, rsmith. tra added a comment. > This is different from nvcc behavior, where it is diagnosed only if the > function is really emitted: That by itself is not a sufficient reason for relaxing the checks. Clang is stricter/more principled in diagnosing other

[PATCH] D83893: [CUDA][HIP] Always defer diagnostics for wrong-sided reference

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: kristof.beyls. When a device function calls a host function or vice versa, this is wrong-sided reference. Currently clang immediately diagnose it. This is different from nvcc behavior, where it is diagnosed