[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. In D83922#2162444 , @jdenny wrote: > In D83922#2162365 , @ABataev wrote: > > > Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could > > you check this, please? > > >

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2162365 , @ABataev wrote: > Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could you > check this, please? It doesn't fail for me, and I didn't receive a buildbot notification. Do you have a

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could check this, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked 3 inline comments as done. jdenny added a comment. Thanks for the review. Will try to push soon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922 ___ cfe-commits mailing list

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else +

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else + MappedVarSet.insert(nullptr); if

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9470-9471 + MappedVarSet.insert(CI->getCapturedVar()->getCanonicalDecl()); +else + MappedVarSet.insert(nullptr); if (CurBasePointers.empty())

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2156567 , @ABataev wrote: > In D83922#2156510 , @jdenny wrote: > > > In D83922#2155749 , @ABataev wrote: > > > > > I would add checks for

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. Check, if it fixed https://bugs.llvm.org/show_bug.cgi?id=46012 Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9468-9469 CurSizes, CurMapTypes, PartialStruct); +if (!CI->capturesThis()) +

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. In D83922#2156510 , @jdenny wrote: > In D83922#2155749 , @ABataev wrote: > > > I would add checks for mapping of `declare target to/link` vars and checked > > if they work in runtime. > >

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2155749 , @ABataev wrote: > I would add checks for mapping of `declare target to/link` vars and checked > if they work in runtime. There are existing codegen tests for that, and they don't seem to be affected by this

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7948-7949 + MapFlagsArrayTy , + const llvm::DenseSet = + llvm::DenseSet()) const {

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny updated this revision to Diff 278546. jdenny marked 7 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. Use `CanonicalDeclPtr`, as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83922/new/ https://reviews.llvm.org/D83922

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7948-7949 + MapFlagsArrayTy , + const llvm::DenseSet = + llvm::DenseSet()) const { // We have to process the component

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. I would add checks for mapping of `declare target to/link` vars and checked if they work in runtime. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9468-9469 CurSizes, CurMapTypes, PartialStruct); +

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel, Meinersbur, kkwli0, grokos, sfantao, gtbercea, Hahnfeld. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. For example, without this patch: $ cat test.c int