[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 280507. dokyungs added a comment. Relanding this reverted commit. (See summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files:

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

This revision was automatically updated to reflect the committed changes. Closed by commit rG12d1124c49be: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when… (authored by dokyungs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 ___ cfe-commits mailing list

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 278613. dokyungs added a comment. Adjusted the comment as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:1092 + // libFuzzer wants to intercept calls to certain library functions, so the + // following -fno-builtin-* flags disable implicit builtin knowledge about + // those functions. Other sanitizers

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs marked an inline comment as done. dokyungs added a comment. Thanks Mitch for the comment! Added a comment that explains that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 278610. dokyungs added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files: clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM w/ nit Comment at: clang/lib/Driver/SanitizerArgs.cpp:1091 + if (Sanitizers.has(SanitizerKind::FuzzerNoLink)) { +CmdArgs.push_back("-fno-builtin-memcmp");

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs created this revision. dokyungs added reviewers: morehouse, hctim. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch disables implicit builtin knowledge about memcmp-like functions when compiling the program for fuzzing, i.e., when