sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/AST/ast-dump-recovery.c:75
+
+ // conditional operator
+ float f;
add to comment: (comparison is invalid)
hokein added inline comments.
Comment at: clang/test/Sema/error-dependence.c:18
+ // type is required" is not emitted.
+ ptr > f ? ptr : f; // expected-error {{invalid operands to binary
expression}}
+}
sammccall wrote:
> nit: parens would help me understand
hokein updated this revision to Diff 296374.
hokein added a comment.
rebase and add ast-dump test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84322/new/
https://reviews.llvm.org/D84322
Files:
clang/lib/Sema/SemaExpr.cpp
sammccall added inline comments.
Comment at: clang/test/Sema/error-dependence.c:18
+ // type is required" is not emitted.
+ ptr > f ? ptr : f; // expected-error {{invalid operands to binary
expression}}
+}
nit: parens would help me understand here :-)
I
