This revision was automatically updated to reflect the committed changes.
aaronpuchert marked an inline comment as done.
Closed by commit rG8ca00c5cdc0b: Thread safety analysis: More consistent
warning message (authored by aaronpuchert).
Changed prior to commit:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a suggestion for a comment, thank you!
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:205
+ /// Warn when calling a
aaronpuchert marked 4 inline comments as done.
aaronpuchert added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:205
+ /// Warn when calling a function that the negative capability is not held.
+ /// \param D -- The decl for the function
aaronpuchert updated this revision to Diff 288820.
aaronpuchert added a comment.
Herald added a subscriber: danielkiss.
Remove "holding" and moved to a separate message because the overlap was
getting smaller.
Also introduced a separate function because it's more consistent with the other
aaron.ballman added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaronpuchert added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaron.ballman added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaronpuchert added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaron.ballman added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaronpuchert added a comment.
@aaron.ballman, can you have a look again? I think this change is consistent
with what we're already doing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84603/new/
https://reviews.llvm.org/D84603
aaronpuchert added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84603/new/
https://reviews.llvm.org/D84603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaronpuchert added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaron.ballman added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1644
if (!LDat) {
- Analyzer->Handler.handleMutexNotHeld("", D, POK, Cp.toString(),
- LK_Shared, Loc);
+
aaronpuchert created this revision.
aaronpuchert added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Other warning messages for negative capabilities also mention their
kind, and the double space was ugly.
Repository:
rG LLVM Github Monorepo
14 matches
Mail list logo
