[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 296267. DiggerLin marked 3 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://reviews.llvm.org/D87451 Files:

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 7 inline comments as done. DiggerLin added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) +

[PATCH] D87451: add new option ignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:2622 + +Do not emit any visibility attribute for asm on AIX or give all symbols 'unspecified' visibility in xcoff object file(XCOFF only) + nit: add a space before parens

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin updated this revision to Diff 295838. DiggerLin marked an inline comment as done. DiggerLin added a comment. address comment and merger the patch https://reviews.llvm.org/D88234 into the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87451: add new option ignore-xcoff-visibility

DiggerLin marked 5 inline comments as done. DiggerLin added inline comments. Comment at: clang/test/CodeGen/aix-no-xcoff-visibility.cpp:75 + +// VISIBILITY-IR:@b = protected global i32 0 +// VISIBILITY-IR:@pramb = hidden global i32 0 jasonliu wrote: >