[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

hoy added a comment. In D88338#2307976 , @sammccall wrote: > Sorry @rsmith @hoy, I've replaced the test with one without such dependencies > in bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb >

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall added a comment. Sorry @rsmith @hoy, I've replaced the test with one without such dependencies in bc18d8d9b705d31a94c51900c8b18e4feaf9c7fb . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

hoy added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:243 + size_t N = 50; + auto xxx = std::string(N, 'x'); +)cpp"; Hi, I'm seeing an error with this "tweak: ExpandAutoType ==> FAIL: Could not deduce type for 'auto'

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

rsmith added inline comments. Comment at: clang-tools-extra/clangd/test/check.test:1 +# RUN: clangd -log=verbose -check 2>&1 | FileCheck -strict-whitespace %s + This test implicitly parses a source file that `#include`s standard library headers, and fails if

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall added a comment. Thanks, I think this fails whenever `compile_commands.json` doesn't exist in the tree or under `build`. (Which of course it does in my local checkout...). Reverted, probably need to rename/copy the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

thakis added a comment. Might break tests: http://45.33.8.238/linux/29238/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88338/new/ https://reviews.llvm.org/D88338 ___ cfe-commits mailing list

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG79fbcbff4173: [clangd] clangd --check: standalone diagnosis of common problems (authored by sammccall).

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks LGTM! Comment at: clang-tools-extra/clangd/tool/Check.cpp:107 + +Cmd = CDB->getFallbackCommand(File); +if (auto TrueCmd = CDB->getCompileCommand(File)) {

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall updated this revision to Diff 295290. sammccall marked 6 inline comments as done. sammccall added a comment. address (some of) comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88338/new/ https://reviews.llvm.org/D88338 Files:

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall added inline comments. Comment at: clang-tools-extra/clangd/tool/Check.cpp:87 +auto Mangler = CommandMangler::detect(); +// Check for missing resource dir? +if (Opts.ResourceDir) kadircet wrote: > i agree, this would help identifying the

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

kadircet added a comment. thanks! this mostly looks good, as discussed offline I believe having an infra that we can improve over time is better than not having anything until we've got the "perfect" solution. i just got a couple of questions about some pieces, and some nits.

[PATCH] D88338: [clangd] clangd --check: standalone diagnosis of common problems

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a tool to simply parse a