This revision was automatically updated to reflect the committed changes.
Closed by commit rL329983: [CMake] Set the default ABI version for Fuchsia in
CMake as well (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
Eric accepted on IRC.
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
phosek added a comment.
In https://reviews.llvm.org/D45529#1066394, @EricWF wrote:
> OK, so we need to bump the SO version -- However I don't want to generate a
> __site_config header because of that if the __config header is sufficient. I
> would like to see a solution that takes that into acc
EricWF added a comment.
OK, so we need to bump the SO version -- However I don't want to generate a
__site_config header because of that if the __config header is sufficient. I
would like to see a solution that takes that into account.
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
phosek updated this revision to Diff 142261.
phosek marked an inline comment as done.
phosek added a comment.
I had something similar in https://reviews.llvm.org/D45304 but Eric suggested
removing it. What I haven't realized is that this value is also used to set the
SOVERSION so it's indeed nee
smeenai added a comment.
This LGTM given that Eric accepted your previous change. I'm happy to accept it
in a day or two if he hasn't gotten the chance to take a look by then.
Comment at: libcxx/CMakeLists.txt:101
+if (FUCHSIA)
+ set(ABI_VERSION_DEFAULT 2)
+else()
---
phosek added a comment.
ping?
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek created this revision.
phosek added reviewers: EricWF, beanz.
Herald added subscribers: cfe-commits, christof, mgorny.
This is neeeded since the CMake value is used for the SOVERSION.
Repository:
rCXX libc++
https://reviews.llvm.org/D45529
Files:
libcxx/CMakeLists.txt
Index: libcx