Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-22 Thread Richard Smith via cfe-commits
On 22 June 2017 at 16:18, Michael Gottesman wrote: > > On Jun 21, 2017, at 4:56 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: > >> On Wed, Jun 21, 2017 at 4:44

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-22 Thread Michael Gottesman via cfe-commits
> On Jun 21, 2017, at 4:56 PM, Richard Smith via cfe-commits > wrote: > > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: > On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Bruno Cardoso Lopes via cfe-commits
On Wed, Jun 21, 2017 at 4:56 PM, Richard Smith wrote: > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: >> >> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith >> wrote: >> > On 21 June 2017 at 14:51, Bruno Cardoso Lopes

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Richard Smith via cfe-commits
On 21 June 2017 at 16:55, Bruno Cardoso Lopes wrote: > On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith > wrote: > > On 21 June 2017 at 14:51, Bruno Cardoso Lopes > > wrote: > >> > >> Hi Richard, > >> > >> Somehow this

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Bruno Cardoso Lopes via cfe-commits
On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith wrote: > On 21 June 2017 at 14:51, Bruno Cardoso Lopes > wrote: >> >> Hi Richard, >> >> Somehow this commit caused some methods in ObjC to do not become >> visible in an interface when compiling with

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Richard Smith via cfe-commits
On 21 June 2017 at 14:51, Bruno Cardoso Lopes wrote: > Hi Richard, > > Somehow this commit caused some methods in ObjC to do not become > visible in an interface when compiling with modules on. I filed > https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

2017-06-21 Thread Bruno Cardoso Lopes via cfe-commits
Hi Richard, Somehow this commit caused some methods in ObjC to do not become visible in an interface when compiling with modules on. I filed https://bugs.llvm.org/show_bug.cgi?id=33552, any idea what could have gone wrong here? `hasVisibleDeclarationImpl` doesn't seem to have changed the logic.

r303322 - [modules] Switch from inferring owning modules based on source location to

2017-05-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed May 17 21:29:20 2017 New Revision: 303322 URL: http://llvm.org/viewvc/llvm-project?rev=303322=rev Log: [modules] Switch from inferring owning modules based on source location to inferring based on the current module at the point of creation. This should result in no