[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

2021-04-27 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } jdoerfert wrote: > thopre

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

2021-04-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } thopre wrote: > I'm getting

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

2021-04-27 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added inline comments. Comment at: llvm/test/Transforms/FunctionAttrs/2008-09-03-ReadOnly.ll:14-15 -; CHECK: attributes #0 = { readonly } +; CHECK: attributes #0 = { nofree readonly } +; CHECK: attributes #1 = { readonly } I'm getting #0 for both

[PATCH] D100226: [funcattrs] Add the maximal set of implied attributes to definitions

2021-04-16 Thread Philip Reames via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf549176ad976: [funcattrs] Add the maximal set of implied attributes to definitions (authored by reames). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM