[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-17 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + arichardson wrote: > This seems to be causing the following warning for me: > > ``` > CMake Warning (dev) at >

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-17 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson added inline comments. Comment at: llvm/CMakeLists.txt:5 +include(GNUInstallDirs) + This seems to be causing the following warning for me: ``` CMake Warning (dev) at

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-07 Thread John Ericson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfeeff8a37c35: [llvm] Use `GNUInstallDirs` to support custom installation dirs (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-07 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added inline comments. Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:1 include(GNUInstallDirs) N.B. this already had it from an earlier revision of mine, so didn't need to add it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-07 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 added a comment. OK, at long last, I this is the attempt that's gonna make it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___ cfe-commits

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-07 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 398219. Ericson2314 marked 4 inline comments as done. Ericson2314 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files:

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-03 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked 4 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-03 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396972. Ericson2314 added a comment. Remove off topic bits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-02 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396872. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated list of projects to build

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-02 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Mark some old threads done. Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-01 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396846. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-01 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396831. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-01 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396825. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-01 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396824. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

2022-01-01 Thread John Ericson via Phabricator via cfe-commits
Ericson2314 updated this revision to Diff 396822. Ericson2314 added a comment. Big rebase and cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: llvm/CMakeLists.txt