xgupta closed this revision.
xgupta added a comment.
Herald added a reviewer: njames93.
Herald added a subscriber: PiotrZSL.
Herald added a project: All.
https://reviews.llvm.org/rG475440703238ca32adab6c3fe5e0039c3f96d1a5 committed
the remaining shebang change from python to python3.
kastiglione added a comment.
Herald added a subscriber: carlosgalvezp.
+1 to committing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101037/new/
https://reviews.llvm.org/D101037
___
cfe-commits
keith added a comment.
@hokein any plans to land this?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101037/new/
https://reviews.llvm.org/D101037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
keith added a comment.
Doesn't seem like anything changed on the mailing list side, should we land
this now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101037/new/
https://reviews.llvm.org/D101037
tdl-g accepted this revision.
tdl-g added a comment.
This revision is now accepted and ready to land.
I'll defer to the consensus on
https://lists.llvm.org/pipermail/cfe-dev/2021-April/068047.html regarding
whether or not there are gotchas for requiring python3,, but assuming tests
have
keith added a comment.
I also have this patch https://reviews.llvm.org/D100692 which changes
run-clang-tidy.py this way as well, specifically because it utilizes some
python3 features in shutil.which
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein created this revision.
Herald added a subscriber: xazax.hun.
hokein requested review of this revision.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D101037
Files:
clang-tools-extra/clang-tidy/add_new_check.py
