[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd30dfa86760c: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer… (authored by mibintc). Repository: rG LLVM Github

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. The changes LGTM, but you should wait a bit before landing in case @rsmith or one of the other reviewers has concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345273. mibintc added a comment. Corrected the failing lit test and applied the clang-format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D101640#2757815 , @mibintc wrote: > In D101640#2757316 , @aaron.ballman > wrote: > >> In D101640#2757178

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757316 , @aaron.ballman wrote: > In D101640#2757178 , @mibintc wrote: > >> In D101640#2757039 , >> @aaron.ballman wrote: >> >>>

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. In D101640#2757178 , @mibintc wrote: > In D101640#2757039 , @aaron.ballman > wrote: > >> Thanks! The last remaining question to me is whether this should be a >> target-specific

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757039 , @aaron.ballman wrote: > Thanks! The last remaining question to me is whether this should be a > target-specific option or whether it makes sense to allow it as an option for > any target. I thought the

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a comment. Thanks! The last remaining question to me is whether this should be a target-specific option or whether it makes sense to allow it as an option for any target. Comment at: clang/include/clang/Basic/LangOptions.def:418-419

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345154. mibintc added a comment. I responded to most all @aaron.ballman 's review comments, may need a little more wordsmithing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + mibintc wrote: > aaron.ballman wrote: > > Can you also add a test for K C functions? e.g., `int knr();` `sum = > > knr(sum, u32, s32, u16, s16, u8,

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added inline comments. Comment at: clang/test/CodeGen/extend-arg-64.c:19 + +int vararg(int, ...); + aaron.ballman wrote: > Can you also add a test for K C functions? e.g., `int knr();` `sum = > knr(sum, u32, s32, u16, s16, u8, s8);` > > Also, can you

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:262-264 +/// Unprototyped integer arguments are extended to 32 bits. +ExtendTo32, +/// Unprototyped integer arguments are extended to 64 bits. The comments

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

jansvoboda11 added a comment. Thanks! This LGTM from command-line perspective, but I'll let others judge the functional change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342750. mibintc added a comment. Responded to suggestions from @jansvoboda11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

jansvoboda11 added a comment. Nice, that looks better. I think we can optimize it a tad by introducing an enum with two cases and store that in `LangOptions` instead of a 32-bit number. Comment at: clang/include/clang/Basic/LangOptions.def:417

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 342478. mibintc retitled this revision from "[clang][patch] Add support for option -fextend-arguments-64: widen integer arguments to int64 in unprototyped function calls" to "[clang][patch] Add support for option -fextend-arguments={32,64}: widen integer