delcypher marked an inline comment as done.
delcypher added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:401
return "aix";
+ case llvm::Triple::Darwin:
+return "darwin";
arphaman wrote:
> Should this also apply to `llvm::Triple::MacOSX`
delcypher updated this revision to Diff 342152.
delcypher added a comment.
- Support other Apple target triples.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101682/new/
https://reviews.llvm.org/D101682
Files:
clang/lib/Driver/ToolChain.cpp
arphaman added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:401
return "aix";
+ case llvm::Triple::Darwin:
+return "darwin";
Should this also apply to `llvm::Triple::MacOSX` , `iOS`, and other Darwin OSes?
Repository:
rG LLVM Github
delcypher created this revision.
delcypher added reviewers: arphaman, dexonsmith, kubamracek, aralisza, yln.
delcypher requested review of this revision.
Herald added a project: clang.
When the Darwin target triple included the OS version number this would cause
`ToolChain::getCompilerRTPath()`
