[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added a comment. Instead of reverting, I fixed the test in rG64e5a3bbdde2 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

phosek added a comment. `OpenMP/tile_codegen_tile_for.cpp` is failing on all our bots, would it be possible to revert the change? FAIL: Clang :: OpenMP/tile_codegen_tile_for.cpp (9951 of 28034) TEST 'Clang :: OpenMP/tile_codegen_tile_for.cpp' FAILED

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07a6beb40215: [Clang][OpenMP] Emit dependent PreInits before directive. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 347508. Meinersbur added a comment. - Merge branch 'arcpatch-D102180' into HEAD - Use SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( ABataev wrote: > Why still

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( Why still `std::vector`? Repository: rG

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345562. Meinersbur marked 2 inline comments as done. Meinersbur added a comment. - Rebase - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12577-12578 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits; + OriginalInits.emplace_back(); if (!OMPLoopBasedDirective::doForAllLoops(

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345029. Meinersbur added a comment. - Preserve relative order between OriginalInits and interleaved transformation's PreInits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344145. Meinersbur added a comment. - Remove unused 'this' capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:8975 +} +return false; })) No need for `return false;` Comment at: clang/lib/Sema/SemaOpenMP.cpp:12607 +

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344134. Meinersbur added a comment. - Don't return false for void lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 344119. Meinersbur added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); ABataev wrote: > Do we need `bool` return

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

ABataev added inline comments. Comment at: clang/lib/AST/StmtOpenMP.cpp:128-129 +llvm::function_ref Callback, +llvm::function_ref +OnTransformationCallback) { CurStmt = CurStmt->IgnoreContainers(); Do we need `bool` return in the callback? I

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. The PreInits of a