[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added a comment. In D102186#2832900 , @predator5047 wrote: > @hans Can you commit on my behalf? > Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Sure! Pushed as

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d404a11dd3: [clang][c++20] Fix false warning for unused private fields when a class has… (authored by Alexandru Octavian Butiu

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 marked an inline comment as done. predator5047 added a comment. @hans Can you commit on my behalf? Email: Alexandru Octavian Butiu alexandru.octavian.butiu at gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 marked an inline comment as done. predator5047 added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; hans wrote: > The test case feels a little strange to me, I mean the

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 updated this revision to Diff 352400. predator5047 added a comment. Updated the test case so it is clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 Files:

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

hans added inline comments. Comment at: clang/test/SemaCXX/warn-unused-private-field.cpp:7 + +class EqDefaultCompare { + int unused_; The test case feels a little strange to me, I mean the member variable is still pretty unused even though I suppose the

[PATCH] D102186: [clang][c++20] Fix false warning for unused private fields when a class has only defaulted comparison operators.

predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102186/new/ https://reviews.llvm.org/D102186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org