[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62b5df7fe2b3: [PowerPC] Added multiple PowerPC builtins (authored by quinnp, committed by stefanp). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

stefanp updated this revision to Diff 348387. stefanp added a comment. Updated author to Quinn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

stefanp updated this revision to Diff 348341. stefanp added a comment. Rebased revision to top of trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 348332. quinnp added a comment. Addressing the last comments made by @nemanjai. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks for implementing this. The redundant pseudo can be removed when committing. Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:2572 +

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

rjmccall added a comment. Alright, that's fine with me, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 ___ cfe-commits mailing list

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 34. quinnp added a comment. This update is motivated by comments made by @nemanjai. All of the builtin names have been changed to follow the convention of __builtin__. To fulfill the original goal of compatibility with the XL compiler, macros have been

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

rjmccall added a comment. The Clang part of this looks fine to me; I can't review the backend changes, but you have partial approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 347029. quinnp added a comment. Adding a comment in BuiltinsPPC.def for motivation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

rjmccall added a comment. If these builtins are generally supposed to be accessed through a compiler-provided header, you could make that header define these functions using underlying builtins that have a `__builtin` prefix. That's not completely necessary, though; we do support some other

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

nemanjai added subscribers: rjmccall, rsmith. nemanjai added a comment. In terms of the motivation for this, the description of the patch should include something along the lines of: "This is the first in a series of patches to provide builtins for compatibility with the XL compiler." Since

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

qiucf added a comment. Is there any motivation to add these builtins? I don't see them implemented in GCC. Besides, in Clang I think a prefix `__builtin` is preferred for them. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:28 +BUILTIN(__popcntb, "ULiULi", "")

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345519. quinnp added a comment. Removed some unused checks in a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345517. quinnp added a comment. Re-added some changes that were lost in the previous updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345515. quinnp added a comment. Removing redundant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345512. quinnp added a comment. [PowerPC] Fixing previous update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp updated this revision to Diff 345510. quinnp added a comment. Fixed some formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102443/new/ https://reviews.llvm.org/D102443 Files: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp Index:

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Most of the builtins already had intrinsics and only needed to be