[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rGb102e6880ab0: [OpenCL] Fix overloading resolution of addrspace constructors (authored by olestrohm). Changed prior to commit: https://reviews.llvm.org/D102850?vs=351165=351388#toc Repository: rG

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, amend the comment as suggested in the final commit Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + // Method overloading is handled above,

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 351165. olestrohm added a comment. Added a comment explaining what the check is meant for. Also added a `CHECK-NOT: used` to properly test that the __generic constructor is not used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102850/new/

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > olestrohm wrote: >

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 350561. olestrohm added a comment. I've reverted to using Constructors and prioritizing based on which constructor is the most qualified. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102850/new/ https://reviews.llvm.org/D102850 Files:

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { olestrohm wrote: > Anastasia wrote: > > olestrohm wrote: > > > Anastasia wrote: >

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > olestrohm wrote: >

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { olestrohm wrote: > Anastasia wrote: > > olestrohm wrote: > > > Anastasia wrote: >

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm updated this revision to Diff 347872. olestrohm added a comment. Made the check more general, it's no longer OpenCL specific and no longer restricted to just constructors, since the check only requires them to be methods. Also added more Sema tests, including using FileCheck to check

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > olestrohm wrote: > > Anastasia wrote: > > > I think we should

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { olestrohm wrote: > Anastasia wrote: > > I think we should remove the OpenCL check

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

olestrohm added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { Anastasia wrote: > I think we should remove the OpenCL check since it is not

[PATCH] D102850: [C++4OpenCL] Fix overloading resolution of addrspace constructors

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9870 + if (S.getLangOpts().OpenCL) { +if (const auto *CD1 = dyn_cast_or_null(Cand1.Function)) { I think we should remove the OpenCL check since it is not OpenCL specific rule