[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-28 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai abandoned this revision. nemanjai added a comment. Thanks everyone for providing feedback on this. I posted this to gauge interest in the community for such a change. As it appears, the consensus seems to be that this isn't desired so I will abandon this change and vendors will

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-27 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D103125#2782096 , @echristo wrote: > I'm also not a fan of this change. From a project perspective the binary is > clang and while people may wish to change the name for their own product > teams it seems like that onus

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-26 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. I'm also not a fan of this change. From a project perspective the binary is clang and while people may wish to change the name for their own product teams it seems like that onus should be on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-26 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. In D103125#2781239 , @jhenderson wrote: > In D103125#2780936 , @dblaikie > wrote: > >> Can't say I'm super enthusiastic about this (I assume the build already >> supports prefixes

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: jhenderson, probinson, dblaikie. dblaikie added a comment. Can't say I'm super enthusiastic about this (I assume the build already supports prefixes and suffixes, which I'd hope would be adequate - but presumably are not for your use case), though there's some, I

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-26 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai created this revision. nemanjai added reviewers: rjmccall, rsmith, craig.topper, t.p.northover, arsenm, kparzysz, echristo. Herald added subscribers: usaxena95, s.egerton, kadircet, arphaman, delcypher, simoncook, mgorny. nemanjai requested review of this revision. Herald added

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

2021-05-26 Thread James Henderson via Phabricator via cfe-commits
jhenderson added a comment. In D103125#2780936 , @dblaikie wrote: > Can't say I'm super enthusiastic about this (I assume the build already > supports prefixes and suffixes, which I'd hope would be adequate - but > presumably are not for your use