[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed in 22aa3680eaccb9b77ca224711c4da3a354aa2d45 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

aaron.ballman accepted this revision. aaron.ballman added a comment. I think this is incremental progress that LGTM, but let's wait a few days in case @rsmith has concerns before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin marked an inline comment as done. cor3ntin added a comment. In D103380#2823746 , @cjdb wrote: > When should we expect this to land? Thanks for the nudge, Chris! Please let me know if I can help move this forward :) Repository: rG LLVM

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb added a comment. When should we expect this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 ___ cfe-commits mailing list

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 349002. cor3ntin added a comment. Move tests to SemaCXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 349000. cor3ntin added a comment. Typos, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

aaron.ballman added a comment. Thanks for working on this! > It does not implement temp.deduct/9. Is there a reason why? Comment at: clang/lib/Sema/SemaConcept.cpp:44 } else if (auto *OO = dyn_cast(E)) { - Op = OO->getOperator(); - LHS = OO->getArg(0); -

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348828. cor3ntin added a comment. Cleanup tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM, but I'm neither a Clang nor core expert (and I'm not a maintainer), so please wait for others' approval. Comment at:

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348759. cor3ntin added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cjdb requested changes to this revision. cjdb added a comment. This revision now requires changes to proceed. Thanks for working on this, it'll be a huge win for testing in libc++, methinks! Could we get a few more tests please? I'd like to know what happens when we put a lambda directly

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin updated this revision to Diff 348693. cor3ntin added a comment. Code formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103380/new/ https://reviews.llvm.org/D103380 Files: clang/lib/Sema/SemaConcept.cpp

[PATCH] D103380: [C++20] Support for lambdas in unevaluated context

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partially implement P0315R4. This patch allow lambda in unevaluated context. It does not implement temp.deduct/9. This is a rewrite of