This revision was automatically updated to reflect the committed changes.
Closed by commit rG936d6756ccfb: [clang][msvc] Define _HAS_STATIC_RTTI to 0,
when compiling with -fno-rtti (authored by zero9178).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rnk accepted this revision.
rnk added a comment.
Seems reasonable to me.
Here is where it is defined in MSVC's yvals_core.h for the curious:
https://github.com/microsoft/STL/blob/3cafa97eecdbfde41ea5c09126f877a7eb97f9e9/stl/inc/yvals_core.h#L569
CHANGES SINCE LAST ACTION
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
(same comment as on https://reviews.llvm.org/D103773)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103771/new/
https://reviews.llvm.org/D103771
thakis added a comment.
Some background https://bugs.chromium.org/p/chromium/issues/detail?id=996675 :
Back then I thought that MSVC switched to /Zc:twoPhase , but that turned out to
not be true. So we never switched the default.
I think this patch here still makes sense, but I admit I don't
zero9178 updated this revision to Diff 350123.
zero9178 added a comment.
Rebase & add comment in source code explaining the purpose of the define
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103771/new/
https://reviews.llvm.org/D103771
Files:
clang/lib/Driver/ToolChains/MSVC.cpp
zero9178 created this revision.
zero9178 added reviewers: rnk, thakis, hans.
zero9178 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When using the -fno-rtti option of the GCC style clang++, using typeid results
in an error. The MSVC STL
