[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-14 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. In D104036#2816602 , @thakis wrote: > Either this or your concurrent commit broke check-clang: > http://45.33.8.238/linux/48839/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This test has

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-14 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Either this or your concurrent commit broke check-clang: http://45.33.8.238/linux/48839/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104036/new/

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-14 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80c0c639687e: [clang][deps] Prevent unintended modifications of the original TU command-line (authored by jansvoboda11). Changed prior to commit:

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-14 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:194 CompilerInstance , DependencyConsumer , - std::map> - OriginalPrebuiltModuleFiles); +

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-13 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one suggestion inline. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:194 CompilerInstance ,

[PATCH] D104036: [clang][deps] Prevent unintended modifications of the original TU command-line

2021-06-10 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One of the goals of the dependency scanner is to provide command-lines that can be used