This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd40e8091bd1f: [PowerPC] Add PowerPC rotate related builtins
and emit target independent code… (authored by NeHuang).
Changed prior to commit:
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM other than a couple of nits.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15064
}
+ case PPC::BI__builtin_ppc_rldimi:
+ case PPC::BI__builtin_ppc_rlwimi: {
NeHuang updated this revision to Diff 358761.
NeHuang marked 4 inline comments as done.
NeHuang added a comment.
Address review comments from Nemanja.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104744/new/
https://reviews.llvm.org/D104744
nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.
Comment at: clang/include/clang/Sema/Sema.h:12559
bool SemaBuiltinOSLogFormat(CallExpr *TheCall);
+ bool CheckPPCisRunOfOnes(CallExpr *TheCall,
NeHuang added a comment.
gentle ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104744/new/
https://reviews.llvm.org/D104744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NeHuang updated this revision to Diff 354082.
NeHuang added a comment.
- Rebased the patch with ToT and the patch https://reviews.llvm.org/D102875
- Create the patch with all contexts. (Thanks @qiucf)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
qiucf added a comment.
Please provide context of the patch (`git diff -U999`) :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104744/new/
https://reviews.llvm.org/D104744
___
cfe-commits mailing list
NeHuang created this revision.
NeHuang added reviewers: nemanjai, stefanp, PowerPC.
NeHuang added projects: LLVM, clang.
Herald added subscribers: shchenz, kbarton.
NeHuang requested review of this revision.
Herald added a subscriber: cfe-commits.
This patch is in a series of patches to provide
