This revision was automatically updated to reflect the committed changes.
Closed by commit rGae5433945f91: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d
to vscale intrinsic or constant. (authored by junparser).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks a lot for making the changes. :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
https://reviews.llvm.org/D104852
junparser updated this revision to Diff 354857.
junparser added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
https://reviews.llvm.org/D104852
Files:
david-arm added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:671
+ case AArch64SVEPredPattern::vl8:
+return NumElts >= Pattern
+ ? Optional(IC.replaceInstUsesWith(
I was actually wondering if we could
junparser updated this revision to Diff 354846.
junparser added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
https://reviews.llvm.org/D104852
Files:
junparser added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:662
+return IC.replaceInstUsesWith(II, StepVal);
+ } else if (Pattern == AArch64SVEPredPattern::vl16 && NumElts == 16) {
+Constant *StepVal =
david-arm added a comment.
Hi @junparser, the patch looks sensible to me! I just had a couple of minor
comments if that's ok.
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:658
+return IC.replaceInstUsesWith(II, VScale);
+ } else if (Pattern >=
junparser added a comment.
@sdesmalen @david-arm @paulwalker-arm kindly ping~
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
https://reviews.llvm.org/D104852
___
cfe-commits mailing list
junparser updated this revision to Diff 354427.
junparser added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
update clang test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104852/new/
