This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGad14b5b008e2: [clang] Stop providing builtin overload
candidate for relational function… (authored by mizvekov).
Changed prior to commit:
mizvekov updated this revision to Diff 354607.
mizvekov added a comment.
- Restore tests.
- Reimplement fixit in terms of variable template (needs -Wno-c++14-extensions).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104892/new/
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
A couple of comments on test coverage but otherwise this looks great, thanks!
It'll be instructive to see if people ask for the warning to not be on by
default...
Comment
mizvekov updated this revision to Diff 354595.
mizvekov added a comment.
- Make it a regular warning.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104892/new/
https://reviews.llvm.org/D104892
Files:
rsmith added a comment.
Thanks, the summary gave me a chuckle :)
Comment at: clang/lib/Sema/SemaExpr.cpp:11809-11812
+Diag(Loc, IsError
+ ? diag::err_typecheck_ordered_comparison_of_function_pointers
+ :
mizvekov created this revision.
mizvekov requested review of this revision.
Herald added projects: clang, Sanitizers.
Herald added subscribers: Sanitizers, cfe-commits.
Word on the grapevine was that the committee had some discussion that
ended with unanimous agreement on eliminating relational
