[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45f6d5522f8d: [DFSan] Change shadow and origin memory layouts to match MSan. (authored by browneee). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

browneee updated this revision to Diff 354558. browneee marked 8 inline comments as done. browneee added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104896/new/ https://reviews.llvm.org/D104896 Files:

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added a comment. Thank you for making this work! Comment at: compiler-rt/lib/dfsan/dfsan.cpp:871 + +static void CheckMemoryLayoutSanity() { + uptr prev_end = 0; Please add a comment about that these CheckMemoryLayoutSanity, ... and

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

stephan.yichao.zhao added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:169 +// TODO(browneee): Removed this after testing and not hit. +CHECK(MEM_IS_SHADOW(s)); +// if (!MEM_IS_SHADOW(s)) { Based on the recent issue about using a

[PATCH] D104896: [DFSan] Change shadow and origin memory layouts to match MSan.

browneee created this revision. browneee added reviewers: stephan.yichao.zhao, gbalats. Herald added subscribers: pengfei, hiraditya. browneee requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.