azabaznov added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412
+!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images",
+ S.getLangOpts( ||
DeclTy->isPipeType()) {
thakis added inline comments.
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7412
+!S.getOpenCLOptions().isSupported("__opencl_c_read_write_images",
+ S.getLangOpts( ||
DeclTy->isPipeType()) {
This revision was automatically updated to reflect the committed changes.
Closed by commit rGab76101f40f8: [OpenCL] Add support of
__opencl_c_read_write_images feature macro (authored by azabaznov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104915/new/
https://reviews.llvm.org/D104915
azabaznov updated this revision to Diff 355890.
azabaznov added a comment.
Fixed naming of new methods, fixed comments, removed redundant comments from
source file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104915/new/
azabaznov updated this revision to Diff 355853.
azabaznov added a comment.
Addressed latest review comments, also refactored the patch by putting
diagnostics into OpenCLOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104915/new/
Anastasia added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10106
def err_opencl_invalid_read_write : Error<
- "access qualifier %0 can not be used for %1 %select{|prior to OpenCL version
2.0}2">;
+ "access qualifier %0 can not be used for
azabaznov created this revision.
azabaznov added reviewers: Anastasia, svenvh.
Herald added subscribers: ldrumm, yaxunl.
Herald added a reviewer: aaron.ballman.
azabaznov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This feature
