[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev added a comment. In D104918#2870582 , @teemperor wrote: > @v.g.vassilev For LLDB you need to change the > `TypeSystemClang::SetExternalSource` function to this (it just moves the > `setHasExternalLexicalStorage` one line up. You can just

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

teemperor added a comment. @v.g.vassilev For LLDB you need to change the `TypeSystemClang::SetExternalSource` function to this (it just moves the `setHasExternalLexicalStorage` one line up. You can just add that change and the compilation fix to this commit. void

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6775fc6ffa3c: [clang-repl] Implement partial translation units and error recovery. (authored by v.g.vassilev). Herald added a project: clang.

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:690-691 + + /// The translation unit is a partial translation unit, growing incrementally. + TU_Partial }; rsmith wrote: > I don't think this is clear enough about the

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev updated this revision to Diff 356015. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104918/new/ https://reviews.llvm.org/D104918 Files:

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

sgraenitz added a comment. A few minor notes Comment at: clang/include/clang/Interpreter/Interpreter.h:63 +if (auto Err = ErrOrPTU.takeError()) return Err; +if (ErrOrPTU->TheModule) `ErrorOr` has different semantics and is still in use, so the

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I'm (happily) surprised this required so few changes! Comment at: clang/include/clang/Basic/LangOptions.h:690-691 + + /// The translation unit is a partial translation

[PATCH] D104918: [clang-repl] Implement partial translation units and error recovery.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, rjmccall, lhames, teemperor, aprantl, sgraenitz, hfinkel. Herald added subscribers: dexonsmith, kbarton, nemanjai. v.g.vassilev requested review of this revision. https://reviews.llvm.org/D96033 contained a discussion